Extract 'dsumEncoder' from chainEncoder#1000
Open
alexfmpe wants to merge 2 commits intoobsidiansystems:developfrom
Open
Extract 'dsumEncoder' from chainEncoder#1000alexfmpe wants to merge 2 commits intoobsidiansystems:developfrom
alexfmpe wants to merge 2 commits intoobsidiansystems:developfrom
Conversation
ryantrinkle
approved these changes
Sep 20, 2024
Member
ryantrinkle
left a comment
There was a problem hiding this comment.
This looks great; thanks!
46ba319 to
cbdd0b0
Compare
Contributor
Author
|
Should I bundle a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to call it
dependentEncodersince it exhibits a bit of context dependent parsing, but then there's the dependent sum aspect and the name would get confusing. While a dependent sum encoder must be ctx dependent, the converse is not true. We can get a simplerby wrapping/unwraping via
Const. I'm tempted to add such a util for convenience but am not coming up with a good name. MaybecontextDependentEncoderon account of it being the simpler such encoder?I have:
developbranchhlint .(lint found code you did not write can be left alone)$(nix-build -A selftest --no-out-link)nix-build release.nix -A build.x86_64-linux --no-out-link(orx86_64-darwinon macOS)